From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 2/6] drm/i915: Remove redundant initialisation of per-ring IRQ waitqueues Date: Tue, 24 Apr 2012 12:14:08 -0700 Message-ID: <20120424121408.7c80bd5e@jbarnes-desktop> References: <1335288691-21819-1-git-send-email-chris@chris-wilson.co.uk> <1335288691-21819-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com [66.147.249.253]) by gabe.freedesktop.org (Postfix) with SMTP id ECF479ED03 for ; Tue, 24 Apr 2012 12:14:12 -0700 (PDT) In-Reply-To: <1335288691-21819-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Apr 2012 18:31:27 +0100 Chris Wilson wrote: > The waitqueues are already initialised during ring initialisation so > kill the redundant and duplicated code to do so in each generations IRQ > installer. > > Signed-off-by: Chris Wilson > --- Yep and that happens before we regsiter the IRQ handler so it looks good. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center