From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: create macros to handle masked
	bits
Date: Tue, 24 Apr 2012 15:45:15 +0200
Message-ID: <20120424134515.GB25770@phenom.ffwll.local>
References: <1335269052-18582-1-git-send-email-daniel.vetter@ffwll.ch>
	<1335273904_37656@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com
	[209.85.215.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2B9839E9DD
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Apr 2012 06:44:16 -0700 (PDT)
Received: by eaak13 with SMTP id k13so192066eaa.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Apr 2012 06:44:15 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1335273904_37656@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Apr 24, 2012 at 02:24:33PM +0100, Chris Wilson wrote:
> On Tue, 24 Apr 2012 14:04:12 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > ... and put them to so good use.
> > 
> > Note that there's functional change in vlv clock gating code, we now
> > no longer spuriously read back the current value of the bit. According
> > to Bspec the high bits should always read zeror, so ORing this in
> s/zeror/zero/
> > should have no effect.
> > 
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> The transforms here look fine, just a moment of concern for not
> repeating the MODE twiddling in init_render_ring after reset.
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the review. If someone has complains, I can
take it out again ;-)
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48