From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 5/6] drm/i915: Handle PendingFlip on gen3 robustly Date: Tue, 24 Apr 2012 21:58:17 +0200 Message-ID: <20120424195817.GA22820@phenom.ffwll.local> References: <1335288691-21819-1-git-send-email-chris@chris-wilson.co.uk> <1335288691-21819-5-git-send-email-chris@chris-wilson.co.uk> <20120424125035.6a495e85@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id BAAED9ED74 for ; Tue, 24 Apr 2012 12:57:22 -0700 (PDT) Received: by werp11 with SMTP id p11so813230wer.36 for ; Tue, 24 Apr 2012 12:57:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120424125035.6a495e85@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 24, 2012 at 12:50:35PM -0700, Jesse Barnes wrote: > On Tue, 24 Apr 2012 18:31:30 +0100 > Chris Wilson wrote: > > - if (dev->primary->master) { > > - master_priv = dev->primary->master->driver_priv; > > - if (master_priv->sarea_priv) > > - master_priv->sarea_priv->last_dispatch = > > - READ_BREADCRUMB(dev_priv); > > - } > > Separate but worthy patch. In fact can we get rid of these at all? > Does anyone still pretend that DRI1 works? We still have to, so it can't go. But if you want some warm fuzzies from removing dri1 crap, look no further than my patch-bomb - there's a patch in there which removes this code for gen5+. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48