From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Use a global lock for modifying global irq flags Date: Wed, 25 Apr 2012 10:21:28 +0200 Message-ID: <20120425082128.GA5079@phenom.ffwll.local> References: <1335300527-8202-1-git-send-email-chris@chris-wilson.co.uk> <20120424140525.51344200@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B18AA0BB1 for ; Wed, 25 Apr 2012 01:20:33 -0700 (PDT) Received: by werp11 with SMTP id p11so1231177wer.36 for ; Wed, 25 Apr 2012 01:20:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120424140525.51344200@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 24, 2012 at 02:05:25PM -0700, Ben Widawsky wrote: > On Tue, 24 Apr 2012 21:48:47 +0100 > Chris Wilson wrote: > > > We were attempting to use a per-ring spinlock whilst modifying global > > IRQ flags. A recipe for rare missed interrupts. > > > > Signed-off-by: Chris Wilson > > Regardless of whether or not this currently fixes anything, I need this > for an upcoming patch. > > Acked-by: Ben Widawsky Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48