From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Bump the inactive LRU on set-to-GTT-domain Date: Wed, 25 Apr 2012 11:04:26 +0200 Message-ID: <20120425090426.GC5079@phenom.ffwll.local> References: <1335279155-13979-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 442429E7C0 for ; Wed, 25 Apr 2012 02:03:27 -0700 (PDT) Received: by wibhm17 with SMTP id hm17so4117488wib.0 for ; Wed, 25 Apr 2012 02:03:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1335279155-13979-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 24, 2012 at 03:52:35PM +0100, Chris Wilson wrote: > Currently, we only bump the LRU of an object when we bind into the GTT > for a page-fault. As the object may be used many times before its > mapping is zapped, we do not mark it as active as frequently as we > should. Userspace should be calling set-to-GTT-domain before each > pointer deference (for synchronous access) and so is a good place > to mark the buffer as active. > > Signed-off-by: Chris Wilson Queued for -next (with an extended commit message as discussed on irc), thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48