From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 4/6] drm/i915: simplify i915_reset a bit
Date: Wed, 25 Apr 2012 13:34:45 -0700
Message-ID: <20120425133445.3dba673f@jbarnes-desktop>
References: <1335355033-3854-1-git-send-email-daniel.vetter@ffwll.ch>
	<1335355033-3854-5-git-send-email-daniel.vetter@ffwll.ch>
	<20120425091821.19fc7808@jbarnes-desktop>
	<20120425202712.GH5079@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6])
	by gabe.freedesktop.org (Postfix) with SMTP id 40D309E78F
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 25 Apr 2012 13:34:51 -0700 (PDT)
In-Reply-To: <20120425202712.GH5079@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 25 Apr 2012 22:27:12 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Wed, Apr 25, 2012 at 09:18:21AM -0700, Jesse Barnes wrote:
> > On Wed, 25 Apr 2012 13:57:11 +0200
> > Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > 
> > > - need_display is always true, scrap it.
> > > - don't reacquire the mutex to do nothing after having restored the
> > >   gem state.
> > > 
> > 
> > Actually I think we generally *don't* need to reset display.  It's
> > currently there just because we haven't tried reset handling without
> > it.  But not resetting display would make resets a little less visible,
> > which would be nice.  Now that you have a nice test setup, can you try
> > testing without the display engine bit set (i.e. only reset render and
> > media at hang time)?
> 
> Imo 'less visible' and gpu hang don't go well together, the 3 second
> freeze plus screen flicker at least ensure that users report bugs. And I
> have no idea whether resetting the entire gpu or just the render portion
> has a greater chance of survival. So I'm not sure whether working on this
> has much benefit ... at least opposed to working on the bugs ;-)

With the CPU/PCH split, display reset is actually a really big hammer.
Theoretically, just doing a render/media reset will be more reliable
and have less chance of wedging the system really hard.

-- 
Jesse Barnes, Intel Open Source Technology Center