From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 6/6] drm/i915: make gpu hangman more
	resilient
Date: Thu, 26 Apr 2012 10:25:27 +0200
Message-ID: <20120426082527.GB5156@phenom.ffwll.local>
References: <1335355033-3854-1-git-send-email-daniel.vetter@ffwll.ch>
	<1335355033-3854-7-git-send-email-daniel.vetter@ffwll.ch>
	<CAC7LmnuSWGfup9Vd9dnH_4BanFguRUj_y8Q1L+Jx-RoaUK2KsA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com
	[209.85.214.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0AC439E826
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 26 Apr 2012 01:24:29 -0700 (PDT)
Received: by bkty7 with SMTP id y7so952062bkt.36
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 26 Apr 2012 01:24:28 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAC7LmnuSWGfup9Vd9dnH_4BanFguRUj_y8Q1L+Jx-RoaUK2KsA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni.dodonov@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Apr 25, 2012 at 11:30:24PM -0300, Eugeni Dodonov wrote:
> On Apr 25, 2012 9:01 AM, "Daniel Vetter" <daniel.vetter@ffwll.ch> wrote:
> > +       /* Also reset the gpu hangman. */
> > +       if (dev_priv->stop_rings) {
> > +               DRM_DEBUG("Simulated gpu hang, resetting stop_rings\n");
> 
> Maybe also print the stop_ring value here?
> 
> > +               dev_priv->stop_rings = 0;
> > +               if (ret) {
> > +                       DRM_ERROR("Ignoring reset failure in simulated
> gpu hang\n");
> 
> ...and error value here as well?
> 
> If we are simulating hangs, I'd guess that we are interested in those
> values..

Well, I think I'll check for -ENODEV only instead because I simply don't
want to kill the gpu and force a module reload just because we don't have
the reset code implemented.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48