From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/12 v2] drm/i915: move vbetool invoked ier stuff Date: Fri, 27 Apr 2012 16:28:10 +0200 Message-ID: <20120427142810.GD5147@phenom.ffwll.local> References: <1335481389-7232-1-git-send-email-ben@bwidawsk.net> <1335481389-7232-4-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 47146A1016 for ; Fri, 27 Apr 2012 07:27:10 -0700 (PDT) Received: by wgbds1 with SMTP id ds1so539917wgb.0 for ; Fri, 27 Apr 2012 07:27:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1335481389-7232-4-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Apr 26, 2012 at 04:03:00PM -0700, Ben Widawsky wrote: > This extra bit of interrupt enabling code doesn't belong in the wait > seqno function. If anything we should pull it out to a helper so the > throttle code can also use it. The history is a bit vague, but I am > going to attempt to just dump it, unless someone can argue otherwise. > > Removing this allows for a shared lock free wait seqno function. To keep > tabs on this issue though, the IER value is stored on error capture > (recommended by Chris Wilson) > > v2: fixed typo EIR->IER (Ben) > Fix some white space (Ben) > Move IER capture to globally instead of per ring (Ben) > > Signed-off-by: Ben Widawsky Queued for -next with the small addition that ier is a 16bit reg on gen2, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48