From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 04/12 v2] drm/i915: kill waiting_seqno
Date: Fri, 27 Apr 2012 16:45:07 +0200
Message-ID: <20120427144507.GE5147@phenom.ffwll.local>
References: <1335481389-7232-1-git-send-email-ben@bwidawsk.net>
	<1335481389-7232-5-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com
	[209.85.214.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9BC5B9E77C
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 27 Apr 2012 07:44:13 -0700 (PDT)
Received: by bkty7 with SMTP id y7so701021bkt.36
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 27 Apr 2012 07:44:12 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1335481389-7232-5-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Apr 26, 2012 at 04:03:01PM -0700, Ben Widawsky wrote:
> The waiting_seqno is not terribly useful, and as such we can remove it
> so that we'll be able to extract lockless code.
> 
> v2: Keep the information for error_state (Chris)
> Check if ring is initialized in hangcheck (Chris)
> Capture the waiting ring (Chris)
> 
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Merged with the comment for the ring->obj == NULL check in hangcheck_idle
clarified, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48