From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 05/12 v2] drm/i915: drop polled waits from i915_wait_request Date: Fri, 27 Apr 2012 16:46:16 +0200 Message-ID: <20120427144615.GF5147@phenom.ffwll.local> References: <1335481389-7232-1-git-send-email-ben@bwidawsk.net> <1335481389-7232-6-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 22611A1017 for ; Fri, 27 Apr 2012 07:45:15 -0700 (PDT) Received: by wgbdr1 with SMTP id dr1so621345wgb.12 for ; Fri, 27 Apr 2012 07:45:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1335481389-7232-6-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Apr 26, 2012 at 04:03:02PM -0700, Ben Widawsky wrote: > The only time irq_get should fail is during unload or suspend. Both of > these points should try to quiesce the GPU before disabling interrupts > and so the atomic polling should never occur. > > This was recommended by Chris Wilson as a way of reducing added > complexity to the polled wait which I introduced in an RFC patch. > > 09:57 < ickle_> it's only there as a fudge for waiting after irqs > after uninstalled during s&r, we aren't actually meant to hit it > 09:57 < ickle_> so maybe we should just kill the code there and fix the breakage > > v2: return -ENODEV instead of -EBUSY when irq_get fails > > Signed-off-by: Ben Widawsky Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48