From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 11/12 v2] drm/i915: wait render timeout ioctl
Date: Sat, 28 Apr 2012 15:18:56 -0700
Message-ID: <20120428151856.10761589@bwidawsk.net>
References: <1335481389-7232-1-git-send-email-ben@bwidawsk.net>
	<1335481389-7232-12-git-send-email-ben@bwidawsk.net>
	<1335516331_66033@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id A0BEE9E737
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 28 Apr 2012 15:20:35 -0700 (PDT)
In-Reply-To: <1335516331_66033@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 27 Apr 2012 09:44:55 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Thu, 26 Apr 2012 16:03:08 -0700, Ben Widawsky <ben@bwidawsk.net>
> wrote:
> > +	mutex_unlock(&dev->struct_mutex);
> > +	ret = __wait_seqno(ring, seqno, true, &timeout);
> > +	drm_gem_object_unreference_unlocked(&obj->base);
> 
> Once we have the seqno to wait on, we can drop the reference to the
> object. The reference to the ring will be persist whilst the device is
> open. Just saves doing an unsightly unlock/lock dance in the unref.
> -Chris
> 

Got it, thanks.