From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 11/12 v2] drm/i915: wait render timeout ioctl
Date: Sat, 28 Apr 2012 19:11:34 -0700
Message-ID: <20120428191134.6c501d1c@bwidawsk.net>
References: <1335481389-7232-1-git-send-email-ben@bwidawsk.net>
	<1335481389-7232-12-git-send-email-ben@bwidawsk.net>
	<1335540301_69364@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id 372D19E747
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 28 Apr 2012 19:13:06 -0700 (PDT)
In-Reply-To: <1335540301_69364@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 27 Apr 2012 16:24:24 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Thu, 26 Apr 2012 16:03:08 -0700, Ben Widawsky <ben@bwidawsk.net>
> wrote:
> > This helps implement glClientWaitSync.
> > 
> > Finally we can use the new timed seqno waiting function to allow
> > userspace to wait on a request with a timeout. This implements that
> > interface.
> > 
> > The new ioctl is very straight forward, there is a flags field
> > which I envision may be useful for various flush permutations of
> > the command.
> 
> What are the semantics of the ioctl? A simple use case would help
> specify the interface here.

The first time I sent out the series, I included the libdrm and igt
test. Is this what you're looking for, or something in the commit
message?

> 
> In particular, I can't tell whether the return value (timeout_ns) is
> meant to be the time elapsed or the time remaining.  What value is
> returned in the timeout if we are interrupted before the wait
> completes? Would
>   end = gettimeofday() + timeout;
>   do {
>     ret = i915_gem_wait(handle, 0, &timeout);
>   } while (ret == -1 && errno == EINTR);
>   assert(gettimeofday() <= end);
> wait forever, or until the original timeout expires?
> -Chris
> 

The return value should give the remaining time left if the return value
was not 0, though I venture to guess you're Socratically trying to tell
me something, so I'll go through this again and find the bug.