From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 4/5] drm/i915: wait render timeout ioctl Date: Tue, 1 May 2012 11:08:44 -0700 Message-ID: <20120501110844.54e34526@bwidawsk.net> References: <1335738156-27706-5-git-send-email-ben@bwidawsk.net> <1335836468-1290-1-git-send-email-ben@bwidawsk.net> <87ehr3rf7q.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id E86299E79D for ; Tue, 1 May 2012 11:08:51 -0700 (PDT) In-Reply-To: <87ehr3rf7q.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 01 May 2012 10:19:53 -0700 Eric Anholt wrote: > On Mon, 30 Apr 2012 18:41:08 -0700, Ben Widawsky wrote: > > This helps implement GL_ARB_sync put stops short of allowing full blow > "but"? "blown"? > > > sync objects. > > > > Finally we can use the new timed seqno waiting function to allow > > userspace to wait on a request with a timeout. This implements that > > interface. > > It looks like this actually lets them wait on a BO with a timeout. I > like it as an interface, but that's not what I expected from the commit > message. Waiting on a request sounds like passing a seqno back out to > userland that they could wait on. Yeah. Chris asked me to update the comments actually, and I forgot. I will resubmit this patch with better comments in the not too distant future.