From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Only enable IPS polling for gen5 Date: Wed, 2 May 2012 14:40:05 +0200 Message-ID: <20120502124004.GD5089@phenom.ffwll.local> References: <1335810902-23287-1-git-send-email-chris@chris-wilson.co.uk> <20120501075827.2c992d0c@jbarnes-desktop> <20120501174502.GC4832@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C8949E90A for ; Wed, 2 May 2012 05:39:00 -0700 (PDT) Received: by eaak13 with SMTP id k13so157960eaa.36 for ; Wed, 02 May 2012 05:38:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120501174502.GC4832@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 01, 2012 at 07:45:02PM +0200, Daniel Vetter wrote: > On Tue, May 01, 2012 at 07:58:27AM -0700, Jesse Barnes wrote: > > On Mon, 30 Apr 2012 19:35:02 +0100 > > Chris Wilson wrote: > > > > > On SandyBridge IPS was entirely implemented in hardware and not reliant > > > on the driver monitoring power consumption and feeding back desired run > > > states, so the hardware is able to adapt quicker and more flexibly. Which > > > is a huge relief for us as we no longer have to carry empirically > > > derived magic algorithms. > > > > > > Yet despite the advance in technology, the driver was still doing its > > > IPS polling on all machines. Restrict it to the only supported hardware, > > > Clarkdale/Arrandale. > > > > > > Signed-off-by: Chris Wilson > > > Cc: Jesse Barnes > > Reviewed-by: Jesse Barnes > Queued for -next, thanks for the patch. Patch is now also in -fixes because it gets rid of a WARN backtrace. Tested-by and bugzilla link added. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48