From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Periodically sanity check power management Date: Thu, 3 May 2012 17:23:02 +0200 Message-ID: <20120503152302.GJ4983@phenom.ffwll.local> References: <1335436122-12101-1-git-send-email-chris@chris-wilson.co.uk> <20120503150754.GI4983@phenom.ffwll.local> <1336058015_131406@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 85E409E803 for ; Thu, 3 May 2012 08:21:57 -0700 (PDT) Received: by werp11 with SMTP id p11so1442414wer.36 for ; Thu, 03 May 2012 08:21:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1336058015_131406@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, May 03, 2012 at 04:13:32PM +0100, Chris Wilson wrote: > On Thu, 3 May 2012 17:07:54 +0200, Daniel Vetter wrote: > > On Thu, Apr 26, 2012 at 11:28:42AM +0100, Chris Wilson wrote: > > > This patch does have a side-effect. It removes the mark-busy for just > > > moving the cursor - we don't want to increase the render clock just for > > > the sprite, though we may want to bump the display frequency. I'd argue > > > that we do not, and certainly don't want to take the struct_mutex here > > > due to the large latencies that introduces. > > > - > > > - if (visible) > > > - intel_mark_busy(dev, to_intel_framebuffer(crtc->fb)->obj); > > > > Hm, what's the reason to drop this one here? > > See above. Oops, pardon me for being blind. Patch queued for -next, thanks. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48