From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/i915: use mode values consistently
 when converting to sdvo dtd
Date: Fri, 4 May 2012 11:35:25 +0200
Message-ID: <20120504093524.GD5443@phenom.ffwll.local>
References: <1335284878-22201-1-git-send-email-daniel.vetter@ffwll.ch>
	<1335295491_40619@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id CB710A0C5D
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  4 May 2012 02:34:19 -0700 (PDT)
Received: by wgbdr1 with SMTP id dr1so2006123wgb.12
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 04 May 2012 02:34:19 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1335295491_40619@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Apr 24, 2012 at 08:24:20PM +0100, Chris Wilson wrote:
> On Tue, 24 Apr 2012 18:27:57 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > The drm_mode->dtd conversion used the crtc timings, whereas the
> > dtd->drm_mod did not set these. Use the standard mode information, not
> > the crtc timings, in both cases to make these two functions proper
> > inverses of each another.
> > 
> > Note that this also kills the risk that we handle interlaced timings
> > inconsistently because the drm core uses half-frames for crtc timings,
> > whereas we need full frames. But interlaced support is pretty decently
> > broken anyway for sdvo encoders, so no big deal.
> 
> So as I understand it, if we had interlacing or dblscan enabled on the
> incoming mode we would have been feeding the display timing into the
> magic black box of the SDVO encoder rather the mode line.
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48