From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 03/12 v2] drm/i915: move vbetool invoked ier stuff Date: Fri, 4 May 2012 12:40:18 -0700 Message-ID: <20120504124018.58d0ba7a@jbarnes-x220> References: <1335481389-7232-1-git-send-email-ben@bwidawsk.net> <1335481389-7232-4-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id 152219E8BB for ; Fri, 4 May 2012 12:40:24 -0700 (PDT) In-Reply-To: <1335481389-7232-4-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 26 Apr 2012 16:03:00 -0700 Ben Widawsky wrote: > This extra bit of interrupt enabling code doesn't belong in the wait > seqno function. If anything we should pull it out to a helper so the > throttle code can also use it. The history is a bit vague, but I am > going to attempt to just dump it, unless someone can argue otherwise. > > Removing this allows for a shared lock free wait seqno function. To > keep tabs on this issue though, the IER value is stored on error > capture (recommended by Chris Wilson) > > v2: fixed typo EIR->IER (Ben) > Fix some white space (Ben) > Move IER capture to globally instead of per ring (Ben) > It may be safe to remove this now. Distros used to run vbetool at random times, shutting things off and messing with hw. But these days they use the driver with a bit less molestation, so the IER check/fix shouldn't be needed. Jesse