From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: disable sdvo hotplug on i945g/gm Date: Sat, 5 May 2012 14:45:29 +0200 Message-ID: <20120505124529.GB11736@phenom.ffwll.local> References: <1336123796-26853-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id E55719E860 for ; Sat, 5 May 2012 05:44:22 -0700 (PDT) Received: by werp11 with SMTP id p11so2758539wer.36 for ; Sat, 05 May 2012 05:44:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1336123796-26853-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Fri, May 04, 2012 at 11:29:56AM +0200, Daniel Vetter wrote: > Chris Wilson dug out a hw erratum saying that there's noise on the > interrupt line on i945G chips. We also have a bug report from a i945GM > chip with an sdvo hotplug interrupt storm (and no apparent cause). > = > Play it safe and disable sdvo hotplug on all i945 variants. > = > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=3D38442 > Reported-and-tested-by: Dominik K=F6ppl > Cc: Chris Wilson > Signed-Off-by: Daniel Vetter I've just realized that this is a regression that has been introduced in 3.1, when we've enabled sdvo hotplug support with commit cc68c81aed7d892deaf12d720d5455208e94cd0a = = Author: Simon Farnsworth = = Date: Wed Sep 21 17:13:30 2011 +0100 = = = = drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI Cc: stable@kernel.org -Daniel > --- > drivers/gpu/drm/i915/intel_sdvo.c | 6 ++++++ > 1 file changed, 6 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/int= el_sdvo.c > index c330efd..bf6be6c 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -1232,8 +1232,14 @@ static bool intel_sdvo_get_capabilities(struct int= el_sdvo *intel_sdvo, struct in > = > static int intel_sdvo_supports_hotplug(struct intel_sdvo *intel_sdvo) > { > + struct drm_device *dev =3D intel_sdvo->base.base.dev; > u8 response[2]; > = > + /* HW Erratum: SDVO Hotplug is broken on all i945G chips, there's noise > + * on the line. */ > + if (IS_I945G(dev) || IS_I945GM(dev)) > + return false; > + > return intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HOT_PLUG_SUPPORT, > &response, 2) && response[0]; > } > -- = > 1.7.10 > = -- = Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48