Re: [PATCH 1/2] drm/i915: Support pageflipping interrupts for all 3-pipes on IVB

Daniel Vetter
2012-05-06T15:33:56Z

On Wed, May 02, 2012 at 12:46:42PM -0700, Jesse Barnes wrote:
> On Wed, 2 May 2012 09:52:12 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > drivers/gpu/drm/i915/i915_irq.c | 31 ++++++++++++++++++++++---------
> > drivers/gpu/drm/i915/i915_reg.h | 7 +++++--
> > 2 files changed, 27 insertions(+), 11 deletions(-)
> >
>
> Highly embarrassing.
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Even more embarrassing that I've failed to pick this up until I've noticed
that lack of a merge conflict that should be there when mergin in -fixes.
We really need some automated tests to check whether pageflipping actually
works on all crtcs ...
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48