From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 04/14] drm/i915: touch the DIP control
 register after enabling the HDMI port
Date: Tue, 8 May 2012 14:29:23 +0200
Message-ID: <20120508122923.GI4802@phenom.ffwll.local>
References: <1336010154-2946-1-git-send-email-przanoni@gmail.com>
	<1336162707-3504-1-git-send-email-przanoni@gmail.com>
	<1336162707-3504-3-git-send-email-przanoni@gmail.com>
	<20120508115950.GE4802@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com
	[209.85.215.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 895649E732
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  8 May 2012 05:28:15 -0700 (PDT)
Received: by eaak13 with SMTP id k13so1759632eaa.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 08 May 2012 05:28:14 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120508115950.GE4802@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, May 08, 2012 at 01:59:50PM +0200, Daniel Vetter wrote:
> On Fri, May 04, 2012 at 05:18:16PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > 
> > This is not documented anywhere, but it seems necessary to make the
> > InfoFrames work, especially when all you have is an HDMI monitor.
> > 
> > Some bugs get fixed just by running "./intel_infoframes -d". This
> > patch fixes this problem on my machine.
> > 
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Can you elaborate a bit on which machines really need this? I fear that
> we're adding a hack here which is only required on a few chips and then
> keep it around forever ...

While reviewing the ilk dip port select change (and looking at gm45 bspec,
too) I've noticed that bspec says we can't change the port while the DIP
stuff is enabled. Could it be that we need to properly disable DIP on dpms
off to ensure that the hw doesn't get confused? We do rewrite all
infoframes in mode_set anyway ...
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48