From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume Date: Thu, 10 May 2012 12:04:11 +0200 Message-ID: <20120510100411.GF4867@phenom.ffwll.local> References: <1334858104.32618.28.camel@atropine> <20120510082919.GA4867@phenom.ffwll.local> <20120510090646.GD4867@phenom.ffwll.local> <1336641962_223397@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DDA69EF20 for ; Thu, 10 May 2012 03:03:03 -0700 (PDT) Received: by eekd17 with SMTP id d17so461011eek.36 for ; Thu, 10 May 2012 03:03:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Takashi Iwai Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, May 10, 2012 at 11:39:49AM +0200, Takashi Iwai wrote: > At Thu, 10 May 2012 10:25:44 +0100, > Chris Wilson wrote: > > > > On Thu, 10 May 2012 11:19:11 +0200, Takashi Iwai wrote: > > > At Thu, 10 May 2012 11:06:46 +0200, > > > Daniel Vetter wrote: > > > > This patch is not just for hotplug, but for all the delayed work and timer > > > > stuff the driver does. And we _do_ have a bug report that leaking the rps > > > > work (for snb+ turbo mode) across either a s/r cycle or a gpu reset kills > > > > the driver. > > > > > > Yes, but my point is that Chris's patch (at least the commit above > > > alone) won't fix the problem we faced. > > > > The patch I thought you two were talking about was: > > http://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=fastboot&id=a5f91dcc3cb7a9dc1214d5014ea6f0338824ad8e > > which is what I thought we had planned to fix the residual issue. > > Thanks, this explains better :) > > But, as far as I checked, the hotplug event wasn't a leftover but > newly triggered during the resume procedure. Thus there is still a > race even with the patch [drm/i915: Cancel outstanding modeset workers > before suspend]. Sorry for the confusion, I've thought the patch I've quoted might fix another bug around s/r, in addition to the hotplug race. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48