From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915/dp: Remove eDP special cases
 from bandwidth checks
Date: Thu, 10 May 2012 21:14:24 +0200
Message-ID: <20120510191424.GA4735@phenom.ffwll.local>
References: <1318610630-20459-1-git-send-email-ajax@redhat.com>
	<1318610630-20459-2-git-send-email-ajax@redhat.com>
	<yun7h46zsry.fsf@aiko.keithp.com>
	<1318872559.7630.56.camel@atropine> <1336675242_230176@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
	[209.85.212.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id 36D3C9E77F
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 10 May 2012 12:13:23 -0700 (PDT)
Received: by wibhm14 with SMTP id hm14so445975wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 10 May 2012 12:13:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1336675242_230176@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, May 10, 2012 at 07:40:23PM +0100, Chris Wilson wrote:
> On Mon, 17 Oct 2011 13:29:18 -0400, Adam Jackson <ajax@redhat.com> wrote:
> > On Fri, 2011-10-14 at 23:13 -0700, Keith Packard wrote:
> > > On Fri, 14 Oct 2011 12:43:50 -0400, Adam Jackson <ajax@redhat.com> wrote:
> > > 
> > > > These were just working around the math being wrong.
> > > 
> > > One wonders whether this might break some machines which are currently
> > > working. Should we emit an error or something if an eDP panel asks for
> > > the impossible?
> > 
> > Probably, but I think in cases where that happens we should be
> > considering the driver to be broken before the panel.  No one's going to
> > manufacture hardware that can't run Windows.
> 
> Sigh, This patch did introduce a number of regressions, notably
> https://bugs.freedesktop.org/show_bug.cgi?id=45801

To clarify, the first patch (fix dp math) broke stuff, not the second one
(rip out edp special case) for this reporter.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48