From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 4/4] drm/i915: s/i915_wait_reqest/i915_wait_seqno/g Date: Sat, 12 May 2012 14:20:14 -0700 Message-ID: <20120512142014.6ecd46df@bwidawsk.net> References: <1336769652-11740-1-git-send-email-ben@bwidawsk.net> <1336769652-11740-4-git-send-email-ben@bwidawsk.net> <4FAD992A.70402@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C7DA9E76B for ; Sat, 12 May 2012 14:21:51 -0700 (PDT) In-Reply-To: <4FAD992A.70402@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: eugeni.dodonov@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 11 May 2012 19:56:42 -0300 Eugeni Dodonov wrote: > On 05/11/2012 05:54 PM, Ben Widawsky wrote: > > Wait request is poorly named IMO. After working with these functions for > > some time, I feel it's much clearer to name the functions more > > appropriately. > > > > Of course we must update the callers to use the new name as well. > > > > This leaves room within our namespace for a *real* wait request function > > at some point. > > > > Note to maintainer: this patch is optional. > > > > Signed-off-by: Ben Widawsky > > My only bikeshedding is to 's/wait_reqest/wait_request' in patch title :). > > Eugeni Thanks. Fixed locally. Daniel, let me know if you want me to resubmit it when you're ready to merge. -- Ben Widawsky, Intel Open Source Technology Center