From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Convert BUG_ON(!pll->active) to a WARN Date: Sun, 13 May 2012 15:42:12 +0200 Message-ID: <20120513134212.GD4720@phenom.ffwll.local> References: <1336899249-2612-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D7D29EAF9 for ; Sun, 13 May 2012 06:41:02 -0700 (PDT) Received: by werc12 with SMTP id c12so1299919wer.36 for ; Sun, 13 May 2012 06:41:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1336899249-2612-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, May 13, 2012 at 09:54:08AM +0100, Chris Wilson wrote: > Turn a fatal lockup into a merely blank display with lots of shouty > messages. > > Signed-off-by: Chris Wilson Queued for -next, thanks for the patch. I guess we could give pll->refcount a similar treatment, but we could also wait with that until it claims it's first victim ;-) -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48