From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: Assert that the transcoder is indeed off before modifying it Date: Mon, 14 May 2012 12:50:45 -0700 Message-ID: <20120514125045.32ef9b71@jbarnes-desktop> References: <1336724485-4451-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id F3C3D9E8C0 for ; Mon, 14 May 2012 12:50:49 -0700 (PDT) In-Reply-To: <1336724485-4451-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 11 May 2012 09:21:25 +0100 Chris Wilson wrote: > Cc: Jesse Barnes > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/intel_display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 8d55dc9..12dba60 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -2878,6 +2878,8 @@ static void ironlake_pch_enable(struct drm_crtc *crtc) > int pipe = intel_crtc->pipe; > u32 reg, temp; > > + assert_transcoder_disabled(dev_priv, pipe); > + > /* For PCH output, training FDI link */ > dev_priv->display.fdi_link_train(crtc); > Seems like a reasonable check. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center