From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] Fix GM965 TV out regression
Date: Sat, 19 May 2012 20:38:20 +0200
Message-ID: <20120519183820.GC4721@phenom.ffwll.local>
References: <05c042c394bc08c0625c8661eb2782d7.squirrel@webmail.exetel.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id DE5FA9E9F8
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 19 May 2012 11:37:02 -0700 (PDT)
Received: by werc12 with SMTP id c12so3079325wer.36
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 19 May 2012 11:37:02 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <05c042c394bc08c0625c8661eb2782d7.squirrel@webmail.exetel.com.au>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Robert Lowery <rglowery@exemail.com.au>, Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sat, May 19, 2012 at 04:52:10PM +1000, Robert Lowery wrote:
> I recently upgraded to ubuntu 12.04 and noticed the TV out no longer works
> with kernel 3.2.0.
> 
> Tracing back through old kernels, I found the last working kernel was 2.6.35.
> 
> Now 4 years ago I fixed a similar issue in the user space intel driver by
> waiting for vblank after writing to the TV_CTL register via
> http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/src/i830_tv.c?id=1142be53eb8d2ee8a9b60ace5d49f0ba27332275
> 
> Low and behold, it appears 2 years later this same issue was reintroduced
> in kernel 2.6.36 and has led to some very unhappy users eg
> https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/763688
> 
> Could someone please apply the following which I have confirmed re-fixes
> the issue for my TV output via component video connection.

Nice piece of diggin through code! A few minor nitpicks on the patch:
- sob-line is missing (see Documentation/SubmittingPatches)
- are there any other people who have tested this patch? If so, please
  include them in the patch with a

  Tested-by: Name <mail@server>

Rodrigo, can you please check this patch with the docs and maybe quickly
run it?

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48