From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/4] [RESEND] drm/i915: s/i915_wait_request/i915_wait_seqno/g Date: Fri, 25 May 2012 14:20:01 +0200 Message-ID: <20120525122001.GF4726@phenom.ffwll.local> References: <1337896991-4795-1-git-send-email-ben@bwidawsk.net> <1337896991-4795-4-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id E8552A0B6E for ; Fri, 25 May 2012 05:18:41 -0700 (PDT) Received: by wgbdr1 with SMTP id dr1so667933wgb.12 for ; Fri, 25 May 2012 05:18:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1337896991-4795-4-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, May 24, 2012 at 03:03:11PM -0700, Ben Widawsky wrote: > Wait request is poorly named IMO. After working with these functions for > some time, I feel it's much clearer to name the functions more > appropriately. > > Of course we must update the callers to use the new name as well. > > This leaves room within our namespace for a *real* wait request function > at some point. > > Note to maintainer: this patch is optional. > > Signed-off-by: Ben Widawsky > Reviewed-by: Eugeni Dodonov I've slurped in the entire series for -next, thanks for the patches. I'll look at the testcase some more over the w/e (I'll be a bit offline), I think we should pimp it with a few more cases. Cheers, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48