From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: reuse the sdvo tv clock adjustment in ilk mode_set Date: Thu, 31 May 2012 09:31:57 +0200 Message-ID: <20120531073156.GC4953@phenom.ffwll.local> References: <1338382346-16044-1-git-send-email-daniel.vetter@ffwll.ch> <1338382593_357080@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 56CAC9E779 for ; Thu, 31 May 2012 00:30:32 -0700 (PDT) Received: by wgbdr1 with SMTP id dr1so469380wgb.12 for ; Thu, 31 May 2012 00:30:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1338382593_357080@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, May 30, 2012 at 01:56:01PM +0100, Chris Wilson wrote: > On Wed, 30 May 2012 14:52:26 +0200, Daniel Vetter wrote: > > Jesse extracted this nice helper in his i9xx_crtc_mode_set refactor, > > but we have the identical code in ironlake_ccrtc_mode_set. And that > > function is huge, so extracting some code full of magic numbers is > > always nice. > > > > Noticed while trying to get a handle on our dp clock code. > > > > Signed-Off-by: Daniel Vetter > Reviewed-by: Chris Wilson Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48