From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 4/4] drm/i915: l3 parity sysfs interface Date: Thu, 31 May 2012 08:55:53 -0700 Message-ID: <20120531085553.12e7eab3@bwidawsk.net> References: <1337990187-6733-1-git-send-email-ben@bwidawsk.net> <1337990187-6733-4-git-send-email-ben@bwidawsk.net> <20120531104556.GE4953@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AD109E747 for ; Thu, 31 May 2012 08:56:02 -0700 (PDT) In-Reply-To: <20120531104556.GE4953@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 31 May 2012 12:45:56 +0200 Daniel Vetter wrote: > On Fri, May 25, 2012 at 04:56:25PM -0700, Ben Widawsky wrote: > > Dumb binary interfaces which allow root-only updates of the cache > > remapping registers. As mentioned in a previous patch, software using > > this interface needs to know about HW limits, and other programming > > considerations as the kernel interface does no checking for these things > > on the root-only interface. > > > > v1: Drop extra posting reads (Chris) > > Return negative values in the sysfs interfaces on errors (Chris) > > > > v2: Return -EINVAL for offset % 4 (Jesse) > > Move schizo userspace check out (Jesse) > > Cleaner sysfs item initializers (Daniel) > > > > Signed-off-by: Ben Widawsky > > I've queued this series for -next. Although you haven't fixed up the one > issue in patch 2 I've noticed and I also don't see my bikeshed for this > patch (despite that you claim to have done so). Whatever, I'll follow up > with patches. > -Daniel Thanks for moving the patches forward, I'll review your fixes to them shortly. The fixes are somewhere; I am not sure how they got lost.