From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 4/4] drm/i915: l3 parity sysfs interface
Date: Thu, 31 May 2012 12:45:56 +0200
Message-ID: <20120531104556.GE4953@phenom.ffwll.local>
References: <1337990187-6733-1-git-send-email-ben@bwidawsk.net>
	<1337990187-6733-4-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com
	[209.85.214.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4E4E09E7E3
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 31 May 2012 03:44:32 -0700 (PDT)
Received: by bkwj4 with SMTP id j4so919168bkw.36
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 31 May 2012 03:44:31 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1337990187-6733-4-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, May 25, 2012 at 04:56:25PM -0700, Ben Widawsky wrote:
> Dumb binary interfaces which allow root-only updates of the cache
> remapping registers. As mentioned in a previous patch, software using
> this interface needs to know about HW limits, and other programming
> considerations as the kernel interface does no checking for these things
> on the root-only interface.
> 
> v1: Drop extra posting reads (Chris)
> Return negative values in the sysfs interfaces on errors (Chris)
> 
> v2: Return -EINVAL for offset % 4 (Jesse)
> Move schizo userspace check out (Jesse)
> Cleaner sysfs item initializers (Daniel)
> 
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

I've queued this series for -next. Although you haven't fixed up the one
issue in patch 2 I've noticed and I also don't see my bikeshed for this
patch (despite that you claim to have done so). Whatever, I'll follow up
with patches.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48