From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fix up ivb plane 3 pageflips
Date: Tue, 5 Jun 2012 21:06:29 +0200
Message-ID: <20120605190629.GC4704@phenom.ffwll.local>
References: <1337772653_201033@CP5-2952>
	<1337774520-26572-1-git-send-email-daniel.vetter@ffwll.ch>
	<20120605085658.GA4704@phenom.ffwll.local>
	<4FCE5580.5090106@linux.intel.com>
	<4FCE5703.4030405@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 367A8A094F
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  5 Jun 2012 12:05:02 -0700 (PDT)
Received: by werc12 with SMTP id c12so4617876wer.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 05 Jun 2012 12:05:01 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <4FCE5703.4030405@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: eugeni.dodonov@intel.com
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jun 05, 2012 at 03:59:15PM -0300, Eugeni Dodonov wrote:
> On 06/05/2012 03:52 PM, Eugeni Dodonov wrote:
> >On 06/05/2012 05:56 AM, Daniel Vetter wrote:
> >>On Wed, May 23, 2012 at 02:02:00PM +0200, Daniel Vetter wrote:
> >>>Or at least plug another gapping hole. Apparrently hw desingers only
> >>>moved the bit field, but did not bother ot re-enumerate the planes
> >>>when adding support for a 3rd pipe.
> >>>
> >>>Discovered by i-g-t/flip_test.
> >>>
> >>>This may or may not fix the reference bugzilla, because that one
> >>>smells like we have still larger fish to fry.
> >>>
> >>>v2: Fixup the impossible case to catch programming errors, noticed by
> >>>Chris Wilson.
> >>>
> >>>References: https://bugs.freedesktop.org/show_bug.cgi?id=50069
> >>>Signed-Off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
> >>
> >>Ping for review and maybe a tested-by. This fixes
> >>i-g-t/tests/flip_test on
> >>my ivb, but for some strange reasons QA can't confirm that. Still, I'd
> >>like to push this patch to -fixes. Eugeni, Ben?
> >
> >Although I don't get exact symptoms (I don't get any BUG in dmesg),
> >without this patch the flip_test hangs when running on 3rd pipe, and
> >with this patch it proceeds and finishes correctly.
> >
> >So this patch fixes this test case, and as far I can see it is correct.
> >
> >Tested-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> 
> ..and also Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Picked up for -fixes (with a cc stable added), thanks for the review and
testing.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48