From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: pch_irq_handler -> {ibx, cpt}_irq_handler Date: Wed, 6 Jun 2012 23:02:33 +0200 Message-ID: <20120606210233.GH4699@phenom.ffwll.local> References: <1339011944-31176-1-git-send-email-ajax@redhat.com> <4FCFC00D.7070701@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 04FDD9E7EF for ; Wed, 6 Jun 2012 14:01:07 -0700 (PDT) Received: by wgbdr1 with SMTP id dr1so5220745wgb.12 for ; Wed, 06 Jun 2012 14:01:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4FCFC00D.7070701@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: eugeni.dodonov@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jun 06, 2012 at 05:39:41PM -0300, Eugeni Dodonov wrote: > On 06/06/2012 04:45 PM, Adam Jackson wrote: > >Cougar/Panther Point redefine the bits in SDEIIR pretty completely. > >This function is just debugging, but if we're debugging we probably want > >to be told accurate things instead of lies. > > > >I'm told Lynx Point changes this yet more, but I have no idea how... > > > >Signed-off-by: Adam Jackson > > Reviewed-by: Eugeni Dodonov > > For the record and for future enabling efforts, for LPT, bits 28-31 > and 1-14 are gone since CPT/PPT (e.g., those must be zero). And > there is the bit 15 as a new addition, but we are not using it yet > and probably won't be using in foreseeable future. Picked up for -fixes with Eugeni's comment added, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48