From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: Switch off FBC when disabling the
 primary plane when obscured
Date: Tue, 12 Jun 2012 07:28:04 -0700
Message-ID: <20120612072804.2ce5f1a8@jbarnes-desktop>
References: <1339501560-31685-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com
	[66.147.249.253])
	by gabe.freedesktop.org (Postfix) with SMTP id E35DA9E975
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 12 Jun 2012 07:28:07 -0700 (PDT)
In-Reply-To: <1339501560-31685-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 12 Jun 2012 12:46:00 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> As we switch on/off the primary plane if it is completely obscured by an
> overlapping video sprite, we also nee to make sure that we update the
> FBC configuration at the same time.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=50238
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---

Yeah looks good.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Though now we have 3 "active" state variables for the crtc don't we?
active, enabled, and now primary_disabled?  Oh and dpms state.  I
really wish we could get rid of 2 or 3 of those...</dreaming>

Jesse