From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 3/4] drm/i915: return -ENOENT if the context
 doesn't exist
Date: Tue, 19 Jun 2012 09:19:11 -0700
Message-ID: <20120619091911.3c4a7bde@bwidawsk.net>
References: <1340117552-3605-1-git-send-email-daniel.vetter@ffwll.ch>
	<1340117552-3605-3-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id 164179E918
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 19 Jun 2012 09:19:19 -0700 (PDT)
In-Reply-To: <1340117552-3605-3-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 19 Jun 2012 16:52:31 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> This is our customary "no such object" errno, not -EINVAL.
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

You've missed idr_cleanup for this. That doesn't get back down to
userspace, but it keeps things consistent.

With that, this is
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> ---
>  drivers/gpu/drm/i915/i915_gem_context.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index 671927a..3d8ae6c 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -455,7 +455,7 @@ int i915_switch_context(struct intel_ring_buffer *ring,
>  	} else {
>  		to = i915_gem_context_get(file_priv, to_id);
>  		if (to == NULL)
> -			return -EINVAL;
> +			return -ENOENT;
>  	}
>  
>  	if (from_obj == to->obj)
> @@ -521,7 +521,7 @@ int i915_gem_context_destroy_ioctl(struct drm_device *dev, void *data,
>  	ctx = i915_gem_context_get(file_priv, args->ctx_id);
>  	if (!ctx) {
>  		mutex_unlock(&dev->struct_mutex);
> -		return -EINVAL;
> +		return -ENOENT;
>  	}
>  
>  	do_destroy(ctx);



-- 
Ben Widawsky, Intel Open Source Technology Center