From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: don't call modeset_init_hw in i915_reset Date: Wed, 20 Jun 2012 11:33:05 +0200 Message-ID: <20120620093305.GC7170@phenom.ffwll.local> References: <1340115069_14722@CP5-2952> <1340124000-2643-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 941189F024 for ; Wed, 20 Jun 2012 02:31:32 -0700 (PDT) Received: by mail-bk0-f49.google.com with SMTP id j4so6732249bkw.36 for ; Wed, 20 Jun 2012 02:31:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1340124000-2643-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 19, 2012 at 06:40:00PM +0200, Daniel Vetter wrote: > It seems to blow up my ilk in all kinds of strange ways. And now that > we're no longer resetting the entire modeset state, it shouldn't be > necessary any longer. > > This essentially reverts > > commit f817586cebf1b946d1f327f9a596048efd6b64e9 > Author: Daniel Vetter > Date: Tue Apr 10 15:50:11 2012 +0200 > > drm/i915: re-init modeset hw state after gpu reset > > safe for the introduction of modeset_init_hw, that one is nice to > prevent code duplication between driver load and resume. > > Signed-Off-by: Daniel Vetter Queued for -next with Chris' irc-comments incorporated. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48