From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 09/14] drm/i915: enable display messages to GT on ValleyView Date: Wed, 20 Jun 2012 15:12:36 +0200 Message-ID: <20120620131236.GI7170@phenom.ffwll.local> References: <1339786526-16747-1-git-send-email-jbarnes@virtuousgeek.org> <1339786526-16747-9-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 25327A0A7F for ; Wed, 20 Jun 2012 06:11:01 -0700 (PDT) Received: by wibhi8 with SMTP id hi8so1306468wib.12 for ; Wed, 20 Jun 2012 06:11:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1339786526-16747-9-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jun 15, 2012 at 11:55:21AM -0700, Jesse Barnes wrote: > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_pm.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index d0ce2a5..4fa1a78 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -3474,6 +3474,13 @@ static void valleyview_init_clock_gating(struct drm_device *dev) > > I915_WRITE(CACHE_MODE_1, > _MASKED_BIT_ENABLE(PIXEL_SUBSPAN_COLLECT_OPT_DISABLE)); > + > + /* > + * On ValleyView, the GUnit needs to signal the GT > + * when flip and other events complete. So enable > + * all the GUnit->GT interrupts here > + */ > + I915_WRITE(VLV_DPFLIPSTAT, 0x3f7f0000); ... can we have less magic here, please? Not that anyone but you seems to have access to docs :( -Daniel > } > > static void g4x_init_clock_gating(struct drm_device *dev) > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48