From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 12/14] drm/i915: don't account for shared interrupts on VLV Date: Wed, 20 Jun 2012 15:18:31 +0200 Message-ID: <20120620131831.GJ7170@phenom.ffwll.local> References: <1339786526-16747-1-git-send-email-jbarnes@virtuousgeek.org> <1339786526-16747-12-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 43F37A0986 for ; Wed, 20 Jun 2012 06:16:58 -0700 (PDT) Received: by bkwj4 with SMTP id j4so6958178bkw.36 for ; Wed, 20 Jun 2012 06:16:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1339786526-16747-12-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jun 15, 2012 at 11:55:24AM -0700, Jesse Barnes wrote: > Only count interrupts we find came from the GPU. > > Signed-off-by: Jesse Barnes We have this on every generation's irq handler this way. I guess we should either fix this everywhere or not bother with it. Dropped for now. -Daniel > --- > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 453ea7c..36732f7 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -515,8 +515,6 @@ static irqreturn_t valleyview_irq_handler(DRM_IRQ_ARGS) > u32 pipe_stats[I915_MAX_PIPES]; > bool blc_event; > > - atomic_inc(&dev_priv->irq_received); > - > while (true) { > iir = I915_READ(VLV_IIR); > gt_iir = I915_READ(GTIIR); > @@ -525,6 +523,8 @@ static irqreturn_t valleyview_irq_handler(DRM_IRQ_ARGS) > if (gt_iir == 0 && pm_iir == 0 && iir == 0) > goto out; > > + atomic_inc(&dev_priv->irq_received); > + > ret = IRQ_HANDLED; > > snb_gt_irq_handler(dev, dev_priv, gt_iir); > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48