From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/3] drm/i915: disable drm agp support for
 !gen3 with kms enabled
Date: Mon, 25 Jun 2012 09:22:20 +0200
Message-ID: <20120625072220.GB4708@phenom.ffwll.local>
References: <1340563898-3687-1-git-send-email-daniel.vetter@ffwll.ch>
	<1340563898-3687-3-git-send-email-daniel.vetter@ffwll.ch>
	<4FE79B56.7070903@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6F95A9E822
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 25 Jun 2012 00:20:42 -0700 (PDT)
Received: by wgbdr1 with SMTP id dr1so2895274wgb.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 25 Jun 2012 00:20:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <4FE79B56.7070903@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: eugeni.dodonov@intel.com
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Sun, Jun 24, 2012 at 07:57:26PM -0300, Eugeni Dodonov wrote:
> On 06/24/2012 03:51 PM, Daniel Vetter wrote:
> > +	/* Only enable AGP support for gen 3. */
> > +	if (intel_info->gen != 3) {
> > +		driver.driver_features &=
> > +			~(DRIVER_USE_AGP | DRIVER_REQUIRE_AGP);
> > +	} else if (!intel_agp_enabled) {
> > +		DRM_ERROR("drm/i915 can't work without intel_agp module!\n");
> > +		return -ENODEV;
> > +	}
> > +
> 
> <bikeshed>
> For the future generations of developers to touch gen3 (or something
> older than gen3 :)), I'd suggest to expand the comment to explain why we
> need it on gen3 and not on all the other gens. I haven't seen this
> commented in any other agpgart killing patches, so perhaps this would be
> the best place.
> </bikeshed>

Well, the older series that rips out the midlayer-ish drm agp
initialization had more justification - we need it to support dead-broken
XvMC on gen3, which is using the old drm add_map stuff to access bos, even
when kms is enabled (gasp!). I'll add this little blurb to the comment
when applying.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48