From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/5] drm/i915: make enable/disable_gt_powersave locking consistent Date: Mon, 25 Jun 2012 21:08:18 +0200 Message-ID: <20120625190818.GD4708@phenom.ffwll.local> References: <1340548956-4097-1-git-send-email-daniel.vetter@ffwll.ch> <1340548956-4097-3-git-send-email-daniel.vetter@ffwll.ch> <4FE79CC9.6010403@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id ED5019F06E for ; Mon, 25 Jun 2012 12:06:40 -0700 (PDT) Received: by werc12 with SMTP id c12so3402254wer.36 for ; Mon, 25 Jun 2012 12:06:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4FE79CC9.6010403@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: eugeni.dodonov@intel.com Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Sun, Jun 24, 2012 at 08:03:37PM -0300, Eugeni Dodonov wrote: > On 06/24/2012 11:42 AM, Daniel Vetter wrote: > > The enable functions grabbed dev->struct_mutex themselves, whereas > > the disable functions expected dev->struct_mutex to be held by the > > caller. Move the locking out to the (currently only) callsite of > > intel_enable_gt_powersave to make this more consistent. > > > > Originally this was prep work for future patches, but I've chased down > > a totally wrong alley. Still, I think this is a sensible > > clarification. > > > > Signed-off-by: Daniel Vetter > > Reviewed-by: Eugeni Dodonov Merged the first two patches of this series to dinq, thanks for the review. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48