From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: disable drm agp support for !gen3
 with kms enabled
Date: Mon, 25 Jun 2012 21:11:36 +0200
Message-ID: <20120625191136.GE4708@phenom.ffwll.local>
References: <20120625072220.GB4708@phenom.ffwll.local>
	<1340632729-6048-1-git-send-email-daniel.vetter@ffwll.ch>
	<1340637552_67276@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
	[209.85.212.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id A475F9E96D
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 25 Jun 2012 12:09:58 -0700 (PDT)
Received: by wibhq4 with SMTP id hq4so2432975wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 25 Jun 2012 12:09:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1340637552_67276@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Jun 25, 2012 at 04:18:32PM +0100, Chris Wilson wrote:
> On Mon, 25 Jun 2012 15:58:49 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > This is the quick&dirty way Dave Airlie suggested to workaround the
> > midlayer drm agp brain-damange. Note that i915_probe is only called
> > when the driver has ksm enabled, so no need to check for that.
> s/ksm/kms/
> > 
> > We also need to move the intel_agp_enabled check at the right place.
> > Note that the only thing this does is enforce the correct module load
> > order (by using a symbol from intel-agp.ko) to ensure that the fake
> > agp driver is ready before the drm core tries to set up the agp stuff.
> > 
> > v2: Add a comment to explain why gen3 needs all this legacy fake agp
> > stuff - we've shipped an XvMC library with a kms-enabled ddx that
> > requires it (but only on gen3).
> > 
> > v3: Make it clear that this is really a gen3 issue only in the
> > comment.
> Make it clear that this is only a gen3 issue in the comment.
>  
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

I've queued all three patches for -next (with the changelog fixed as
suggested), thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48