From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 19/21] drm/i915: prevent bogus intel_update_fbc notifications Date: Thu, 28 Jun 2012 21:24:11 +0200 Message-ID: <20120628192411.GF5596@phenom.ffwll.local> References: <1340909749-15249-1-git-send-email-eugeni.dodonov@intel.com> <1340909749-15249-20-git-send-email-eugeni.dodonov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 2763EA0A43 for ; Thu, 28 Jun 2012 12:24:15 -0700 (PDT) Received: by wibhm11 with SMTP id hm11so310557wib.12 for ; Thu, 28 Jun 2012 12:24:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1340909749-15249-20-git-send-email-eugeni.dodonov@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eugeni Dodonov Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 28, 2012 at 03:55:47PM -0300, Eugeni Dodonov wrote: > This pollutes dmesg output even if we do not have FBC for the device, so > move the DRM_DEBUG_KMS statement lower. > > Signed-off-by: Eugeni Dodonov I suggest we just kill this right away ;-) -Daniel > --- > drivers/gpu/drm/i915/intel_pm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index a4372b3..0ccdb96 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -387,14 +387,14 @@ void intel_update_fbc(struct drm_device *dev) > struct drm_i915_gem_object *obj; > int enable_fbc; > > - DRM_DEBUG_KMS("\n"); > - > if (!i915_powersave) > return; > > if (!I915_HAS_FBC(dev)) > return; > > + DRM_DEBUG_KMS("\n"); > + > /* > * If FBC is already on, we just have to verify that we can > * keep it that way... > -- > 1.7.11.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48