Re: [PATCH 19/21] drm/i915: prevent bogus intel_update_fbc notifications

Daniel Vetter
2012-06-28T19:24:15Z

On Thu, Jun 28, 2012 at 03:55:47PM -0300, Eugeni Dodonov wrote:
> This pollutes dmesg output even if we do not have FBC for the device, so
> move the DRM_DEBUG_KMS statement lower.
>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

I suggest we just kill this right away ;-)
-Daniel
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index a4372b3..0ccdb96 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -387,14 +387,14 @@ void intel_update_fbc(struct drm_device *dev)
> struct drm_i915_gem_object *obj;
> int enable_fbc;
>
> - DRM_DEBUG_KMS("\n");
> -
> if (!i915_powersave)
> return;
>
> if (!I915_HAS_FBC(dev))
> return;
>
> + DRM_DEBUG_KMS("\n");
> +
> /*
> * If FBC is already on, we just have to verify that we can
> * keep it that way...
> --
> 1.7.11.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48