Re: [PATCH 07/21] drm/i915: re-initialize DDI buffer translations after resume

Eugeni Dodonov
2012-07-04T23:11:34Z

On 07/04/2012 05:35 PM, Daniel Vetter wrote:
> On Wed, Jul 04, 2012 at 05:07:39PM -0300, Paulo Zanoni wrote:
>> 2012/6/28 Eugeni Dodonov <eugeni.dodonov@intel.com>:
>>> This is necessary for the modesetting to work correctly after a
>>> suspend-resume cycle. Without this, the pipes and clocks got the correct
>>> configuration, but the underlying DDI buffers configuration was lost.
>>>
>>> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
>>
>> I couldn't make suspend/resume work on my machine yet, but running
>> intel_prepare_ddi again after resume won't hurt us, so:
>>
>> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Queued for -next, thanks for the patch. Quick aside: I think we have a
> similar issue with the hsw power well init code.

Yes, I'll send the power wells patch until the end of the week as well,
sorry for taking that long!

Eugeni