Re: [PATCH 19/21] drm/i915: prevent bogus intel_update_fbc notifications

Paulo Zanoni
2012-07-04T17:41:23Z

2012/6/28 Eugeni Dodonov <eugeni.dodonov@intel.com>:
> This pollutes dmesg output even if we do not have FBC for the device, so
> move the DRM_DEBUG_KMS statement lower.
>
> v2: just kill the message as suggested by Daniel.
>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

The message first says we "move the statement lower", but then later
it says we kill the message :)
With that fixed:

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

I'm happy with both v1 and v2.

> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 53645f1..42e847c 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -387,8 +387,6 @@ void intel_update_fbc(struct drm_device *dev)
> struct drm_i915_gem_object *obj;
> int enable_fbc;
>
> - DRM_DEBUG_KMS("\n");
> -
> if (!i915_powersave)
> return;
>
> --
> 1.7.11.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni