Re: [PATCH 13/21] drm/i915: add RPS configuration for Haswell

Eugeni Dodonov
2012-06-29T13:47:45Z

On 06/29/2012 06:56 AM, Daniel Vetter wrote:
> Ok, after reviewing this with the gen6 code and hsw power doc I see very
> few differences (besides the 2 things that look like mistakes):
> - we don't set a few things related to rc6p&rc6pp
> - we have slightly different timeout/threshold values.
>
> When copy&pasting code we should balance the risk of introducing
> regressions with the risk to not apply bugfixes everywhere they're needed.
> Given that you've missed Jesse's fix while hacking on this and that this
> seems to work very much like rps on snb/ivb I'd vote for sprinkling a few
> ifs into gen6_enable_rps. Maybe set the timing values in local variables
> at the beginning of the function.

Sure, I'll do this and send the patch.

Eugeni