Re: [PATCH 07/21] drm/i915: re-initialize DDI buffer translations after resume

Paulo Zanoni
2012-07-04T20:07:39Z

2012/6/28 Eugeni Dodonov <eugeni.dodonov@intel.com>:
> This is necessary for the modesetting to work correctly after a
> suspend-resume cycle. Without this, the pipes and clocks got the correct
> configuration, but the underlying DDI buffers configuration was lost.
>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

I couldn't make suspend/resume work on my machine yet, but running
intel_prepare_ddi again after resume won't hurt us, so:

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> ---
> drivers/gpu/drm/i915/intel_display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 28bee8a..76508a7 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7179,6 +7179,8 @@ static void ivb_pch_pwm_override(struct drm_device *dev)
>
> void intel_modeset_init_hw(struct drm_device *dev)
> {
> + intel_prepare_ddi(dev);
> +
> intel_init_clock_gating(dev);
>
> mutex_lock(&dev->struct_mutex);
> @@ -7208,8 +7210,6 @@ void intel_modeset_init(struct drm_device *dev)
>
> intel_init_pm(dev);
>
> - intel_prepare_ddi(dev);
> -
> intel_init_display(dev);
>
> if (IS_GEN2(dev)) {
> --
> 1.7.11.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni