Re: [PATCH 19/21] drm/i915: prevent bogus intel_update_fbc notifications

Eugeni Dodonov
2012-07-04T23:17:09Z

On 07/04/2012 02:41 PM, Paulo Zanoni wrote:
> 2012/6/28 Eugeni Dodonov <eugeni.dodonov@intel.com>:
>> This pollutes dmesg output even if we do not have FBC for the device, so
>> move the DRM_DEBUG_KMS statement lower.
>>
>> v2: just kill the message as suggested by Daniel.
>>
>> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
>
> The message first says we "move the statement lower", but then later
> it says we kill the message :)
> With that fixed:
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> I'm happy with both v1 and v2.

I'll let Daniel decide the bike shed color on this one :). We can always
say that 'move it down' was a slang term for 'killing' later :).

Eugeni