From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fix up ilk rc6 disabling confusion
Date: Sat, 30 Jun 2012 07:51:13 +0200
Message-ID: <20120630055113.GA5072@phenom.ffwll.local>
References: <1341005536-5324-1-git-send-email-daniel.vetter@ffwll.ch>
	<4FEE3BEE.8030002@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com
	[209.85.215.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 06C7B9ED5A
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 29 Jun 2012 22:51:21 -0700 (PDT)
Received: by eaaf11 with SMTP id f11so1666927eaa.36
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 29 Jun 2012 22:51:21 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <4FEE3BEE.8030002@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: eugeni.dodonov@intel.com
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Jun 29, 2012 at 08:36:14PM -0300, Eugeni Dodonov wrote:
> On 06/29/2012 06:32 PM, Daniel Vetter wrote:
> > @@ -7270,6 +7270,8 @@ void intel_modeset_cleanup(struct drm_device *dev)
> >  
> >  	intel_disable_gt_powersave(dev);
> >  
> > +	ironlake_teardown_rc6(dev);
> > +
> 
> Couldn't we pass a true/false parameter to the
> intel_disable_gt_powersave for tearing down ironlake RC6 directly instead?
> 
> Something like
> intel_disable_gt_powersave(struct drm_device *dev, bool teardown_context);
> 
> maybe?

Well, I want to separate setup/teardown code that we only run at driver
load and unload time from hw enable/disable code that we also need to run
around suspend/resume. So no, I explicitly don't want such convoluted
stuff any more. Similarly for code that checks at resume time whether
things are set up already, e.g. the ringbuffer stuff or contexts.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48