Re: [PATCH 1/4] drm/i915: don't return a spurious -EIO from intel_ring_begin

Chris Wilson
2012-07-03T16:00:59Z

My experience with these patches is that they make it less likely that
the hang is reported to the userspace in a timely fashion (filling the
ring full leads to lots of lost rendering) and worse make it much more
likely that i915_gem_fault() hits an EIO and goes bang. That is
unacceptable and trivial to hit with these patches. I have not yet
reproduced that issue using the same broken renderer without these
patches.

I do think the patches are a step in the right direction, but with the
change in userspace behaviour it has to be a NAK for the time being.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre