From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fix up ilk rc6 disabling confusion
Date: Wed, 4 Jul 2012 09:38:51 +0200
Message-ID: <20120704073851.GC5375@phenom.ffwll.local>
References: <1341005536-5324-1-git-send-email-daniel.vetter@ffwll.ch>
	<20120630200444.71e4b92d@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5E7099E7B3
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  4 Jul 2012 00:38:53 -0700 (PDT)
Received: by wibhm11 with SMTP id hm11so3693033wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 04 Jul 2012 00:38:52 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120630200444.71e4b92d@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Jun 30, 2012 at 08:04:44PM -0700, Ben Widawsky wrote:
> On Fri, 29 Jun 2012 23:32:16 +0200
> Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> 
> > While creating the new enable/disable_gt_powersave functions in
> > 
> > commit 8090c6b9daa04dda649ac0a2209601042abfb0a4
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Sun Jun 24 16:42:32 2012 +0200
> > 
> >     drm/i915: wrap up gt powersave enabling functions
> > 
> > I've botched up the handling of ironlake_disable_rc6. Fix this up by
> > calling it at the right place. Note though that ironlake_disable_rc6
> > does a bit more than just disabling rc6 - it also tears down all the
> > allocated context objects.
> 
> I can only hope that one day you will appreciate the API I set up in
> the context code to handle this.
> 
> > 
> > Hence we need to move intel_teardown_rc6 out and directly call it from
> > intel_modeset_cleanup.
> 
> I don't mind that you've done this, however could you explain/modify the
> comment when we want to disable without destroying the backing context
> object?
> 
> > 
> > Also properly mark ironlake_enable_rc6 as static and kill the un-used
> > declaration in i915_drv.h.
> > 
> > Cc: Ben Widawsky <ben@bwidawsk.net>
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
Queued for -next (with a little comment added as discussed), thanks for
the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48