From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 19/21] drm/i915: prevent bogus intel_update_fbc notifications Date: Thu, 5 Jul 2012 09:47:35 +0200 Message-ID: <20120705074735.GA5203@phenom.ffwll.local> References: <20120628192411.GF5596@phenom.ffwll.local> <1340914303-32278-1-git-send-email-eugeni.dodonov@intel.com> <4FF4CF7C.6070401@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id ED9989EC2A for ; Thu, 5 Jul 2012 00:47:43 -0700 (PDT) Received: by wibhm11 with SMTP id hm11so4417698wib.12 for ; Thu, 05 Jul 2012 00:47:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4FF4CF7C.6070401@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: eugeni.dodonov@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 04, 2012 at 08:19:24PM -0300, Eugeni Dodonov wrote: > On 07/04/2012 02:41 PM, Paulo Zanoni wrote: > > 2012/6/28 Eugeni Dodonov : > >> This pollutes dmesg output even if we do not have FBC for the device, so > >> move the DRM_DEBUG_KMS statement lower. > >> > >> v2: just kill the message as suggested by Daniel. > >> > >> Signed-off-by: Eugeni Dodonov > > > > The message first says we "move the statement lower", but then later > > it says we kill the message :) > > With that fixed: > > > > Reviewed-by: Paulo Zanoni > > > > I'm happy with both v1 and v2. > > I'll let Daniel decide the bike shed color on this one :). We can always > say that 'move it down' was a slang term for 'killing' later :). I've already merged it, but forgot to send out the ack mail ;-) -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48