From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 5/6] drm/i915: Handle framebuffer offsets[]
Date: Thu, 5 Jul 2012 13:29:36 +0200
Message-ID: <20120705112936.GG5203@phenom.ffwll.local>
References: <1337882939-22274-1-git-send-email-ville.syrjala@linux.intel.com>
	<1337882939-22274-6-git-send-email-ville.syrjala@linux.intel.com>
	<20120524113132.5a7e6f6c@jbarnes-desktop>
	<20120524184915.GL13065@intel.com>
	<20120524190124.GG5078@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id 26E96A0E6D
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  5 Jul 2012 04:29:41 -0700 (PDT)
Received: by wgbdr1 with SMTP id dr1so6340243wgb.12
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 05 Jul 2012 04:29:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20120524190124.GG5078@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, May 24, 2012 at 09:01:24PM +0200, Daniel Vetter wrote:
> On Thu, May 24, 2012 at 09:49:15PM +0300, Ville Syrj=E4l=E4 wrote:
> > On Thu, May 24, 2012 at 11:31:32AM -0700, Jesse Barnes wrote:
> > > On Thu, 24 May 2012 21:08:58 +0300
> > > ville.syrjala@linux.intel.com wrote:
> > > =

> > > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > > =

> > > > Take fb->offset[0] into account when calculating the linear and til=
e x/y
> > > > offsets.
> > > > =

> > > > For non-tiled surfaces fb->offset[0] is simply added to the linear
> > > > byte offset.
> > > > =

> > > > For tiled surfaces treat fb->offsets[0] as a byte offset into the
> > > > linearized view of the surface. So we end up converting fb->offsets=
[0]
> > > > into additional x and y offsets.
> > > =

> > > Do you have code using a non-zero offsets[0]?  At least for current
> > > code that would indicate some kind of problem... though hopefully we'=
ll
> > > be adding planar support back again sometime soon.
> > =

> > I did have some test app that used offsets[] at some point, but tbh I
> > didn't excercise these changes with it.
> > =

> > I have a sort of semi working skeleton of a test app which I just modify
> > for various use cases as need arises. I really should try to clean it up
> > a bit and generalize it so that it wouldn't need constant code changes
> > to test different scenarios.
> =

> Yeah, I want these little test apps as testcases in i-g-t.

Ping about these testcases, ported to i-g-t ...
-Daniel
-- =

Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48