Re: [PATCH 5/6] drm/i915: Handle framebuffer offsets[]

Ville Syrjälä
2012-05-24T18:49:15Z

On Thu, May 24, 2012 at 11:31:32AM -0700, Jesse Barnes wrote:
> On Thu, 24 May 2012 21:08:58 +0300
> ville.syrjala@linux.intel.com wrote:
>
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Take fb->offset[0] into account when calculating the linear and tile x/y
> > offsets.
> >
> > For non-tiled surfaces fb->offset[0] is simply added to the linear
> > byte offset.
> >
> > For tiled surfaces treat fb->offsets[0] as a byte offset into the
> > linearized view of the surface. So we end up converting fb->offsets[0]
> > into additional x and y offsets.
>
> Do you have code using a non-zero offsets[0]? At least for current
> code that would indicate some kind of problem... though hopefully we'll
> be adding planar support back again sometime soon.

I did have some test app that used offsets[] at some point, but tbh I
didn't excercise these changes with it.

I have a sort of semi working skeleton of a test app which I just modify
for various use cases as need arises. I really should try to clean it up
a bit and generalize it so that it wouldn't need constant code changes
to test different scenarios.

--
Ville Syrjälä
Intel OTC