From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fix up PCH backlight #define mixup
Date: Wed, 11 Jul 2012 00:36:59 +0200
Message-ID: <20120710223659.GD5108@phenom.ffwll.local>
References: <1341959466-1564-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 09AC69EBA3
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 10 Jul 2012 15:36:58 -0700 (PDT)
Received: by weyr3 with SMTP id r3so385459wey.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 10 Jul 2012 15:36:58 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1341959466-1564-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jul 11, 2012 at 12:31:06AM +0200, Daniel Vetter wrote:
> I so totally suck.
> 
> This can cause a black screen if (for whatever reason) the bios
> hasn't set this bit itself.
> 
> This regression has been introduced in
> 
> commit 7cf4160148136deb31ee5f2802857dd935a38529
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Tue Jun 5 10:07:09 2012 +0200
> 
>     drm/i915: clear up backlight #define confusion on gen4+
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51463
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

>>From irc:

Tested-by: Kenneth Graunke <kenneth@whitecape.org>

-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48