From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] reg_read: basic register read ioctl test Date: Thu, 12 Jul 2012 10:06:00 +0200 Message-ID: <20120712080600.GB5039@phenom.ffwll.local> References: <1342051656-32481-1-git-send-email-ben@bwidawsk.net> <1342051680-32560-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTP id E6A49A0E9E for ; Thu, 12 Jul 2012 01:06:00 -0700 (PDT) Received: by wibhm2 with SMTP id hm2so4829268wib.0 for ; Thu, 12 Jul 2012 01:06:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1342051680-32560-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 11, 2012 at 05:08:00PM -0700, Ben Widawsky wrote: > This will need to get modified when the ioctl expands, and so is only > here for reference/to make Daniel happy. > = > Signed-off-by: Ben Widawsky If you go with the (offset, size) table to check things, I think you should add a test to read a valid reg offset, but with the wrong size. Otherwise this looks good. -Daniel > --- > tests/drm_reg_read.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 86 insertions(+) > create mode 100644 tests/drm_reg_read.c > = > diff --git a/tests/drm_reg_read.c b/tests/drm_reg_read.c > new file mode 100644 > index 0000000..d28039b > --- /dev/null > +++ b/tests/drm_reg_read.c > @@ -0,0 +1,86 @@ > +/* > + * Copyright =A9 2012 Intel Corporation > + * > + * Permission is hereby granted, free of charge, to any person obtaining= a > + * copy of this software and associated documentation files (the "Softwa= re"), > + * to deal in the Software without restriction, including without limita= tion > + * the rights to use, copy, modify, merge, publish, distribute, sublicen= se, > + * and/or sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice (including the = next > + * paragraph) shall be included in all copies or substantial portions of= the > + * Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILI= TY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SH= ALL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR = OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISI= NG > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER D= EALINGS > + * IN THE SOFTWARE. > + * > + * Authors: > + * Ben Widawsky > + * > + */ > + > +#include > +#include > +#include "i915_drm.h" > +#include "drmtest.h" > + > +struct local_drm_i915_reg_read { > + __u64 offset; > + __u32 size; > + __u64 val; /* Return value */ > + __u32 pad; > +}; > + > + > +#define REG_READ_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x30, struct local_dr= m_i915_reg_read) > + > +static void handle_bad(int ret, int lerrno, int expected, const char *de= sc) > +{ > + if (ret !=3D 0 && lerrno !=3D expected) { > + fprintf(stderr, "%s - errno was %d, but should have been %d\n", > + desc, lerrno, expected); > + exit(EXIT_FAILURE); > + } else if (ret =3D=3D 0) { > + fprintf(stderr, "%s - Command succeeded, but should have failed\n", > + desc); > + exit(EXIT_FAILURE); > + } > +} > + > +int main(int argc, char *argv[]) > +{ > + struct local_drm_i915_reg_read read; > + int ret, fd; > + > + read.offset =3D 0x2358; > + read.size =3D 4; > + > + fd =3D drm_open_any(); > + > + ret =3D drmIoctl(fd, REG_READ_IOCTL, &read); > + if (ret) { > + perror("positive test case failed\n"); > + exit(EXIT_FAILURE); > + } > + > + /* bad reg */ > + read.offset =3D 0x12345678; > + ret =3D drmIoctl(fd, REG_READ_IOCTL, &read); > + handle_bad(ret, errno, ENXIO, "bad register"); > + > + /* bad size */ > + read.offset =3D 0x2358; > + read.size =3D 5; > + ret =3D drmIoctl(fd, REG_READ_IOCTL, &read); > + handle_bad(ret, errno, EINVAL, "bad size"); > + > + close(fd); > + > + exit(EXIT_SUCCESS); > +} > -- = > 1.7.11.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48